hashicorp / react-components

A set of HashiCorp branded react components currently maintained and used by the marketing dev team
https://react-components.vercel.app
Mozilla Public License 2.0
60 stars 17 forks source link

fix(consent-manager): filter additional services in main component #956

Closed pbortnick closed 1 year ago

pbortnick commented 1 year ago

🎟️ [Asana Task]() 🔍 Preview Link


Description

This PR fixes the (most recent consent-manager change)[] and filters the additionalServices by their optional shouldLoad field in the main component rather than the <CustomScript /> component. This solves an issue where we were still seeing the service in the <ConsentPreferences /> dialog when shouldLoad() was false

See this canary version in use here

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: a834bcbae2fb77c9f62b75baa5fa8ffc5411724c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------------- | ----- | | @hashicorp/react-consent-manager | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 6:25pm
github-actions[bot] commented 1 year ago

:package: Canary Packages Published

Latest commit: a834bcbae2fb77c9f62b75baa5fa8ffc5411724c

Published 1 packages #### @hashicorp/react-consent-manager@9.1.1-canary-20230505182613 ``` npm install @hashicorp/react-consent-manager@canary ```