feat(inline video): add `videoClassName` prop

pbortnick commented 1 year ago

🎟️ [Asana Task]() 🔍 Preview Link

Description

This PR adds the optional videoClassName prop so that we can add custom styles that may be needed, such as border, box shadows, etc.

This is related to some updates being made to the dotcom about page.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

[ ] Add Asana and Preview links above.
[ ] Conduct thorough self-review.
[ ] Add or update tests as appropriate.
[ ] Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
[ ] Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
[ ] Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 5:07pm

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ac7d356b1f45dcdd8fde5f10560f423cfd7bc0a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------------ | ----- | | @hashicorp/react-inline-video | Minor | | @hashicorp/react-video-feature | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nandereck commented 1 year ago

Out of curiosity, what are the style changes to the InlineVideo component for the about page?

pbortnick commented 1 year ago

Out of curiosity, what are the style changes to the InlineVideo component for the about page?

@nandereck we have a video who's thumbnail is mostly white making it blend into a white background. We want to apply these styles to give it some dimension

nandereck commented 1 year ago

We want to apply these styles to give it some dimension

Oh, cool that makes sense!

hashicorp / react-components