Namespace rpc proto, update go-plugin

hashicorp / sentinel-sdk

This SDK allows developers to extend Sentinel to source external information for use in their policies.

Mozilla Public License 2.0

51 stars 13 forks source link

Closed vancluever closed 5 years ago

vancluever commented 5 years ago

This does a couple of things:

Namespaces our RPC protocol to hashicorp.sentinel.proto. This ensures there are no conflicts with any of our other products, libraries, or anything else that may try to use the global namespace.
Updates the plugin interfaces so that the latest go-plugin can be used correctly.

A new version of the Sentinel Simulator will follow soon that will support the new namespace set here.

Fixes #12.

vancluever commented 5 years ago

@dadgar ^^^

mitchellh commented 5 years ago

This looks good to me but would like to see Alex’s review too.

dadgar commented 5 years ago

LGTM

vancluever commented 5 years ago

🎉 going in now!