search

hashicorp / sentinel-sdk

This SDK allows developers to extend Sentinel to source external information for use in their policies.
Mozilla Public License 2.0
51 stars 13 forks source link

sdk: move GetKey field in GetReq to a value slice #26

Closed vancluever closed 5 years ago

vancluever commented 5 years ago

This moves the Keys field to type []GetKey instead of []*GetKey.

This is possibly a matter of personal preference but after some discussion internally there are some marginal benefits, namely with nil not being meaningful in this context.

vancluever commented 5 years ago

Depends on #25.

mwhooker commented 5 years ago

Looks good to me. The GetKey structs looks like a collection of pointers anyway (string, slice of interfaces which are pointers themselves..), so shouldn't be too different from the way it was before.