search

hashicorp / sentinel-sdk

This SDK allows developers to extend Sentinel to source external information for use in their policies.
Mozilla Public License 2.0
51 stars 13 forks source link

Rename all references of import to be plugin #55

Closed cam-stitt closed 2 years ago

cam-stitt commented 2 years ago

In preparation of some changes that are happening to the Sentinel runtime, we are renaming import to plugin in all locations.

This is a backwards incompatible change and will require a minor bump of the sdk.

The failing tests are expected due to the cyclic dependency between the sdk and sentinel.

glennsarti commented 2 years ago

This is a backwards incompatible change

If this is a breaking change then shouldn't this be a major bump?

Does this require consumers of the SDK to recompile their plugins? Feels like this is missing some migration steps for consumers.

Will Sentinel support both types of RPC services? .Import and .Plugin?

cam-stitt commented 2 years ago

This is a backwards incompatible change

If this is a breaking change then shouldn't this be a major bump?

Does this require consumers of the SDK to recompile their plugins? Feels like this is missing some migration steps for consumers.

Will Sentinel support both types of RPC services? .Import and .Plugin?

sentinel-sdk currently has no major version. We are currently not yet at v1.0, so this would bump the minor version the same way prior breaking changes have.