hashicorp / serf

Service orchestration and management tool.
https://github.com/hashicorp/serf/blob/master/docs/index.html.markdown
Mozilla Public License 2.0
5.88k stars 596 forks source link

go.mod: upgrade to go 1.16 #653

Closed huikang closed 2 years ago

huikang commented 2 years ago
dhiaayachi commented 2 years ago

Hey @huikang , The go version in the go mod file represent the minimal (oldest) go version that can be used with the library. I'm not sure we have to upgrade it to go 1.18 for serf as we don't use any 1.18 only feature in this library.

huikang commented 2 years ago

Hi, @dhiaayachi , thanks for the comment. I hit some issue when compiling the code due to incompatibility issue with golang.org/x/sys/unix. So I test changing the go version and upgrade the go.sum for that package.

The new commit has reverted the minimal version to 1.12. Please take another look. Thanks.