search

hashicorp / serf

Service orchestration and management tool.
https://github.com/hashicorp/serf/blob/master/docs/index.html.markdown
Mozilla Public License 2.0
5.88k stars 596 forks source link

Upgrade armon/go-metrics to hashicorp/go-metrics #693

Open mkeeler opened 1 year ago

mkeeler commented 1 year ago

Also bumping hashicorp/memberlist to the corresponding version which also uses hashicorp/go-metrics

This will require a new major version to signify that metrics are using different global handlers.

TODO:

puffpuf commented 1 year ago

can someone merge it, please?

peczenyj commented 1 year ago

+1 here

I need to the line below several go.mod files and it is annoying

replace github.com/armon/go-metrics v0.5.1 => github.com/hashicorp/go-metrics v0.5.1

peczenyj commented 1 year ago

fix issue #707

alex-savin commented 11 months ago

+1 here

peczenyj commented 8 months ago

any reason to not merge it ?

adamrothman commented 8 months ago

@mkeeler @hashi-derek can we get some 👀 on this?

frebib commented 6 months ago

Bump please; without this patch, this library is completely unusable/broken for anyone using it, or pulling in something that uses it

shane-ns1 commented 4 months ago

Wow this PR is more than a year old! Is the repository completely unmaintained? :grimacing:

peczenyj commented 4 months ago

@shane-ns1 looks like ...

peczenyj commented 4 months ago

perhaps we should start to ping @dhiaayachi and other people that can merge on this repo

shane-ns1 commented 4 months ago

perhaps we should start to ping @dhiaayachi and other people that can merge on this repo

Or even @armon? :laughing:

jmurret commented 4 months ago

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state. This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.