search

hashicorp / serf

Service orchestration and management tool.
https://github.com/hashicorp/serf/blob/master/docs/index.html.markdown
Mozilla Public License 2.0
5.88k stars 596 forks source link

Please, Upgrade armon/go-metrics to hashicorp/go-metrics #707

Open peczenyj opened 12 months ago

peczenyj commented 12 months ago

The package armon/go-metrics was renamed to hashicorp/go-metrics

however, I need to add replace directives in my go.mod files to keep the vendors updated.

can we just update the dependencies and release again?

Dentrax commented 3 months ago

Just hit this issue. I was wondering if there are any updates on this?

cc @badrabubker

rboyer commented 3 months ago

Quoting @jmurret's reply on a related PR:

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state. This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.

godcong commented 2 weeks ago

hashicorp/go-metrics updated several versions... You can't update this one, or you'll get an error.