search

hashicorp / setup-terraform

Sets up Terraform CLI in your GitHub Actions workflow.
https://developer.hashicorp.com/terraform/tutorials/automation/github-actions
Mozilla Public License 2.0
1.35k stars 237 forks source link

feat: bump to use node20 runtime #346

Closed chenrui333 closed 10 months ago

chenrui333 commented 1 year ago

Closes #366

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)

Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0. Node16 has en end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather then node16

relates to https://github.com/actions/runner/pull/2732

chenrui333 commented 1 year ago

needs a major version release after the PR merge

chenrui333 commented 1 year ago

cc @bendbennett , this is ready to go. 🙏

chenrui333 commented 11 months ago

cc @austinvalle

chenrui333 commented 11 months ago

I dont understand what is going on, can someone help take a look at this?

chenrui333 commented 10 months ago

@austinvalle updated the action refs and rebased to the latest master, also add the changelog entry. Let me know if it works better now. Thanks!

chenrui333 commented 10 months ago

@austinvalle all green 🎉

chenrui333 commented 10 months ago

LGTM, I pushed a couple changes to the PR:

  • Reverted some of the changes to .github/workflows/continuous-integration.yml, unforuntately our GH organization is limited to specific SHA commits of workflows that are approved. These are managed by a separate system so I just kept the node upgrades 👍🏻
  • Switched the changelog entry to be a changie entry

Thanks for your patience and contribution @chenrui333! I'm going to be releasing v3.0.0 early next week once I merge a couple other PRs into setup-terraform

Sounds good and thank you for getting this going!

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.