Unless commented in this PR, the following files/paths were copied without modification and are likely safe to skip during review:
.storybook/*
addon/components/*
app/components/*
import paths updated to reflect new package name (@hashicorp/pds-ember instead of product-design-system)
app/styles/*
blueprints/*
docs/*
tests/dummy/*
tests/unit/*
import paths updated to reflect new package name (@hashicorp/pds-ember instead of product-design-system)
Storybook v6!
Apparently in #9, a yarn install automatically updated Storybook to version 6. Fortunately, it appears that there are no major issues with our current content and Storybook 6.
CONS:
The browser console will likely spit out warnings to point out code in story files that would benefit from the latest syntax. These warnings will be addressed in a future PR.
PROS:
The generated props table now displays the correct default values and now also displays the "type" below the description!
Storybook navigation is now easier to navigate (better organized with sections instead of sub-folders).
Summary
How to Build and Test the Change
cd packages/pds-ember
yarn start
yarn storybook
yarn
commands should not error (warnings are ok)Review Notes
Unless commented in this PR, the following files/paths were copied without modification and are likely safe to skip during review:
.storybook/*
addon/components/*
app/components/*
@hashicorp/pds-ember
instead ofproduct-design-system
)app/styles/*
blueprints/*
docs/*
tests/dummy/*
tests/unit/*
@hashicorp/pds-ember
instead ofproduct-design-system
)Storybook v6!
Apparently in #9, a
yarn install
automatically updated Storybook to version 6. Fortunately, it appears that there are no major issues with our current content and Storybook 6.Nav (v5):
Nav (v6):
Button args (v5):
Button args (v6):