search

hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

Investigate using a11y-disabled-modifier #101

Closed meirish closed 1 year ago

meirish commented 2 years ago

This was in the most recent issue of ember times - the issue is that when a button is disabled, a screen reader can't focus it so it can't be read. This modifier https://github.com/chriskrycho/a11y-disabled-modifier uses aria attributes to implement an accessible pattern for disabling buttons.

We should look at adding this to Pds::Button when @disabled is true.

MelSumner commented 2 years ago

@meirish when an interactive icon is disabled, it is supposed to be ignored by assistive technology (AT).

From the addon: Most of the time, you shouldn't use this at all: prefer to provide feedback on form submission instead!

Maybe as a stopgap or a transitional phase?

Happy to discuss more if we think that a unified approach to forms in HC apps would be useful.

didoo commented 1 year ago

Outdated. Closing now.