HCS-2269: change tooltip to class modifier to allow updates

hashicorp / structure

Structure (aka "PDS") [deprecated]

https://hashicorp-structure.vercel.app

Mozilla Public License 2.0

24 stars 5 forks source link

HCS-2269: change tooltip to class modifier to allow updates #105

Closed ellacai closed 2 years ago

ellacai commented 3 years ago

Changes

change tooltip to be a class modifier so we can control when tooltip is destroyed
fixes issue in hcp where tooltip displaying polled data disappears after 1 sec, now it persists + updates

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/structure/DHUYWVD3fZ3v4kapmi8VZRuVTykp
✅ Preview: https://structure-git-hcs-2269-hashicorp.vercel.app

meirish commented 3 years ago

Could you add a test that verifies the new behavior too? https://github.com/hashicorp/structure/tree/main/packages/pds-ember/tests/integration/modifiers/tooltip