refactoring spike for accessibility conformance

hashicorp / structure

Structure (aka "PDS") [deprecated]

https://hashicorp-structure.vercel.app

Mozilla Public License 2.0

24 stars 5 forks source link

refactoring spike for accessibility conformance #107

Closed MelSumner closed 2 years ago

MelSumner commented 2 years ago

Not for merging.

Refactored where I could, to see what it would be like to make this component accessible.

Three issues:

open/close toggle doesn't work
needs focus trap
styling can't yet tell the difference between a list item with just text and a list item with an interactive item (so padding is not consistent)

Screenshot:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/structure/8WWu41CBQBQXp6dfjweonPNZHBXV
✅ Preview: https://structure-git-melsumner-dropdown-hashicorp.vercel.app

hashicorp-cla commented 2 years ago

All committers have signed the CLA.

didoo commented 2 years ago

@MelSumner do you think we can close this PR/Draft (and delete the associated branch)?