Closed didoo closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
structure | ✅ Ready (Inspect) | Visit Preview | Jul 25, 2022 at 10:21AM (UTC) |
@jgwhite @meirish @cbfx @jesdavpet at the moment I have not received any comment, so… I’m going to interpret it as implicit approval :). Any objections?
Description
Now that the
Pds::Banner
andPds::Popup
components have been migrated in Cloud UI toHds::Alert
andHds::Toast
, we can remove these two components from the Structure codebase.Changes
In this PR I have
Pds::Banner
component (tests and documentation included)Pds::Popup
component (tests and documentation included)Testing
I have symlinked my local directory
package/pds-ember
to the `` folder in Cloud UI, run the application and tested that everything worked as expected.Notice: the current implementation may fail because an instance of
<Pds::Banner>
has been recently introduced by @noelledaley in this commit; I asked here to replace it with the corresponding<Hds::Alert>
component so this deprecation can move forward.Relevant links