hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

Deprecation - Remove `Pds::ErrorState` / `Pds::Loading` / `Pds::Modal` / `Pds::Copyright + Pds::Logomark` components #119

Closed didoo closed 1 year ago

didoo commented 1 year ago

Description

While working on https://github.com/hashicorp/structure/pull/117 and https://github.com/hashicorp/structure/pull/118 I realized there's an extra group of components that can be removed, because they're not used in Cloud UI:

Also, I noticed that Pds::Copyright and Pds::Logomark could be moved inside the Pds::GlobalFooter component, since they're used only there.

Changes

In this PR I have

Testing

I have symlinked my local directory package/pds-ember to the `` folder in Cloud UI, run the application and tested that everything worked as expected.

Relevant links

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
structure ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 6:29AM (UTC)
didoo commented 1 year ago

@jgwhite @meirish @cbfx @jesdavpet at the moment I have not received any comment, so… I’m going to interpret it as implicit approval :). Any objections?