Closed didoo closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
structure | ✅ Ready (Inspect) | Visit Preview | Jul 28, 2022 at 6:29AM (UTC) |
@jgwhite @meirish @cbfx @jesdavpet at the moment I have not received any comment, so… I’m going to interpret it as implicit approval :). Any objections?
Description
While working on https://github.com/hashicorp/structure/pull/117 and https://github.com/hashicorp/structure/pull/118 I realized there's an extra group of components that can be removed, because they're not used in Cloud UI:
Pds::ErrorState
Pds::Loading
Pds::Modal
Also, I noticed that
Pds::Copyright
andPds::Logomark
could be moved inside thePds::GlobalFooter
component, since they're used only there.Changes
In this PR I have
Pds::ErrorState
component (tests and documentation included)Pds::Loading
component (tests and documentation included)Pds::Modal
component (tests and documentation included)Pds::Copyright
andPds::Logomark components inside
Pds::GlobalFooter`Testing
I have symlinked my local directory
package/pds-ember
to the `` folder in Cloud UI, run the application and tested that everything worked as expected.Relevant links