Deprecation - Remove `Pds::ExternalLink` component

didoo commented 1 year ago

Description

While working on another task related to removing the usage of Pds::Icon in Structure, I noticed that the Pds::ExternalLink component is not really used in Cloud UI (there's a placeholder component that prevents using it) This means we can remove this component from the Structure codebase (this will also simplify the task of removing instances of Pds::Icon in Structure.

Changes

In this PR I have

removed entirely the Pds::ExternalLink component (tests and documentation included)
added Storybook documentation files for the deprecated component
- ExternalLink

Testing

I haven't tested directly this, as I did for other components before, because in any case the temporary component in Cloud UI would use the namespace Pds::ExternalLink so there's no breakings in any case.

Relevant links

https://github.com/hashicorp/cloud-ui/pull/2052

Things to do once this PR is merged and the new Structure version is adopted in Cloud UI

there is one single case in which the .pds--external class name is used, in this file: https://github.com/hashicorp/cloud-ui/blob/master/packages/cloud-ui-core/addon/components/copy-card/index.hbs#L15 - we need to remove that class and if needed^1 add an equivalent "local" style for that component (copy-card)
- after a more thorough check seems it's actually not needed: if you remove the class in the DOM, nothing happens, and I don't see styles associated with it

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
structure	✅ Ready (Inspect)	Visit Preview	Sep 19, 2022 at 9:26PM (UTC)

didoo commented 1 year ago

@jesdavpet @cbfx can you have a look at this PR and let me know if it's OK for you, if you see any downside at removing the Pds::ExternalLink component? (this will facilitate my work on https://github.com/hashicorp/structure/pull/126 too). thanks

hashicorp / structure