Now that the main "app" layout (and sidebar navigation) have been completely refactored in Cloud UI we can finally start to remove a bunch of app-related components from Structure (and other components that were blocked by these components removal).
Changes
In this PR I have
removed the following components/subcomponents (tests and documentation included)
Pds::App component with subcomponents
Pds::App::Banner
Pds::App::Body
Pds::App::Drawer
Pds::App::Footer
Pds::App::Header
Pds::App::ModalArea
Pds::App::Sidebar
Pds::Button
Pds::CtaLink
Pds::Dropdown
Pds::Global[Header|Footer]
Pds::Nav
Pds::PageHeader
Pds::Page
added Storybook documentation files for the deprecated component
I have symlinked my local directory package/pds-ember to the cloud-ui/node_modules/@hashicorp/pds-ember folder in Cloud UI, run the application and tested that everything worked as expected.
Things I've found will need to be fixed, once the new Structure version is going to be adopted in Cloud UI:
still using <Pds::App> for testing purposes, needs to switch to the new page layout components
other instances (in comments, storybook stories, etc) of other components, but we will need to look at things case by case and do a general cleanup of all the remnants of these deprecated components
Description
Now that the main "app" layout (and sidebar navigation) have been completely refactored in Cloud UI we can finally start to remove a bunch of app-related components from Structure (and other components that were blocked by these components removal).
Changes
In this PR I have
removed the following components/subcomponents (tests and documentation included)
Pds::App
component with subcomponentsPds::App::Banner
Pds::App::Body
Pds::App::Drawer
Pds::App::Footer
Pds::App::Header
Pds::App::ModalArea
Pds::App::Sidebar
Pds::Button
Pds::CtaLink
Pds::Dropdown
Pds::Global[Header|Footer]
Pds::Nav
Pds::PageHeader
Pds::Page
added Storybook documentation files for the deprecated component
Testing
I have symlinked my local directory
package/pds-ember
to thecloud-ui/node_modules/@hashicorp/pds-ember
folder in Cloud UI, run the application and tested that everything worked as expected.Things I've found will need to be fixed, once the new Structure version is going to be adopted in Cloud UI:
packages/cloud-ui-core/addon/styles/components/clipboard-copy-button/index.scss
Pds::Button
, we need to copy&paste them locally in the componentpackages/cloud-ui-core/addon/styles/components/layout/sidebar-subnav-header.scss
nav/header
, we need to copy&paste them locallypackages/cloud-ui-core/addon/styles/components/layout/sidebar-subnav-item.scss
nav/link
, we need to copy&paste them locallyaddons/data-visualizations/tests/dummy/app/templates/application.hbs
<Pds::App>
for testing purposes, needs to switch to the new page layout componentsRelevant links