search

hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

Storybook setup #2

Closed meirish closed 4 years ago

meirish commented 4 years ago

Adds storybook setup and blueprints that will create stories when generating an st-component.

joshuaogle commented 4 years ago

Looks good 👍 The component and addon commands worked great.

Trying to run storybook before storybook:docs-deploy gave me an error because the dist directory wasn't there yet. Is that expected? Also, just curious, do we intend for people to need to go into the structure-core package to do some of these commands or do we plan on surfacing those at the root level?

meirish commented 4 years ago

Thanks for looking @joshuaogle! Running storybook needs to be done with yarn start in another tab - the server doesn't stop output to the terminal so you can't run it in one command like you can the storybook:docs-deploy does. I think for now, most of the work will be done in the various folders in packages so you'll need to switch folders, but for stuff like the storybook build, you make a good point that it could be moved to the root as well. I'll add that here!

meirish commented 4 years ago

Added that top-level command, so I'm going to go ahead and merge this! Thanks for taking a look.