hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

fix(pds-ember): correct line height of Pds::Select component #31

Closed CITguy closed 3 years ago

CITguy commented 3 years ago

<select> and <Pds::Icon> vertical alignment is being affected by their line-height (both of which are larger than 1, so they have extra whitespace above their content, shifting elements and characters downward

BEFORE

select - before

AFTER

select - after

meirish commented 3 years ago

@CITguy didn't want this to fall off of the radar, but the Safari styling is still odd: CleanShot 2020-10-29 at 12 22 13