search

hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

feat(pds-ember): add Toolbar, Divider, and "ghost" CtaLink #60

Closed CITguy closed 3 years ago

CITguy commented 3 years ago

JIRA: PDS-209

Screenshots

Select

before fix Select - before fix

after fix Select - after fix

Divider

horizontal (default) Divider - Horizontal (default)

vertical Divider - Vertical

Toolbar

basic layout Toolbar - basic layout

pattern: List Toolbar - Pattern - List

pattern: Details Toolbar - Pattern - Details

pattern: Editor Toolbar - Pattern - Editor

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/structure/he0ygp282
✅ Preview: https://structure-git-feat-toolbar.hashicorp.vercel.app

CITguy commented 3 years ago

Thanks @meirish!

While refactoring links with the Global Header stuff, I've been thinking about where CtaLink fits in the classification hierarchy. The Ember component is 100% a hyperlink, but the CSS is very much a Button, so it makes sense to classify the styles as a Button variant (i.e., "button/cta"), because the only difference is how "disabled" appearance is applied (:disabled vs .pds--disabled). Otherwise, the styles kinda sit in limbo between Link and Button.