search

hashicorp / structure

Structure (aka "PDS") [deprecated]
https://hashicorp-structure.vercel.app
Mozilla Public License 2.0
24 stars 5 forks source link

chore(pds-ember): move storybook stories to the /tests folder #90

Closed meirish closed 3 years ago

meirish commented 3 years ago

When attempting to add a modifier that included a third-party library, it was necessary to move ember-auto-import from devDependencies to dependencies. Doing this, however, caused an error saying that the addon code was trying to import @storybook/addon-knobs, so it should be moved to dependencies instead of devDependencies.

We don't want Storybook and related code to end up in compiled output so the solution I landed on was to move the intermingled story files from the /addon dir to alongside the component integration tests in the /tests folder.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/structure/AZ5pMdC97djWSnyw92jz5NkhACbc
✅ Preview: https://structure-git-stories-in-test-folder-hashicorp.vercel.app