Skip HCP tests on PRs - Githubissues

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)

https://www.consul.io/docs/ecs

Mozilla Public License 2.0

52 stars 31 forks source link

Skip HCP tests on PRs #126

Closed pglass closed 2 years ago

pglass commented 2 years ago

Changes proposed in this PR:

This updates CI and acceptance tests to skip the HCP tests on PRs.

The way this works is:

Pass either -var enable_hcp=true|false to setup-terraform to control whether an HCP Consul cluster is created.
HCP tests look for the enable_hcp output variable in setup-terraform, and skip themselves if there is no HCP cluster.
In CI, we set enable_hcp=true for main and release/* branches. Otherwise, it is set to false.

For the moment, no enterprise tests will run on PRs, which I'll address in a follow up using the dev-server.

How I've tested this PR:

Acceptance tests

How I expect reviewers to test this PR:

👀

Checklist:

[x] Tests added
[ ] ~CHANGELOG entry added~