hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 31 forks source link

Address cluster capacity provider deprecation notice #127

Closed pglass closed 2 years ago

pglass commented 2 years ago

Changes proposed in this PR:

This addresses the deprecated capacity provider warning in setup-terraform. We now use the separate aws_ecs_capacity_providers resource instead of the field in the aws_ecs_cluster resource.

I refactored the Terraform resources to use resource counts, and moved the ec2 instance creation into a sub module. This makes it easy to change the number of ECS clusters we spin up.

How I've tested this PR:

Acceptance tests

How I expect reviewers to test this PR:

👀

Checklist: