hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 31 forks source link

Use Login API instead of the CLI #132

Closed pglass closed 2 years ago

pglass commented 2 years ago

Changes proposed in this PR:

These changes match https://github.com/hashicorp/consul-ecs/pull/115 to use the Login API. This only required removing the ExtraLoginFields option from the ConsulLogin config object. I also updated the consul_ecs_config var to support passing the additional login fields.

How I've tested this PR:

How I expect reviewers to test this PR:

👀

Checklist:

cthain commented 2 years ago

Oh, just realized that this probably needs a changelog entry since it adds the consulLogin field and associated validation to the config file.

pglass commented 2 years ago

I updated gateway-task in recent commits.