hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Fix gossip key ARN #133

Closed cthain closed 2 years ago

cthain commented 2 years ago

Changes proposed in this PR:

Fix a bug in the dev-server where it doesn't pick up the correct secret ARN for the gossip encryption key when the module is configured to generate the gossip key. When var.gossip_encryption_enabled = true the module is supposed to create and use a gossip key. However, when gossip_encryption_enabled = true it was always using the value of var.gossip_key_secret_arn, even if that was unset (which it should be in the case where the key is generated). This caused the creation of the execution role policy to fail because the Resource ARN for gossip key secret was the empty string.

How I've tested this PR:

How I expect reviewers to test this PR:

:eyes:

Checklist: