search

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 31 forks source link

v0.5.1 is incompatible with Consul Enterprise v1.13.3 #145

Closed v-rosa closed 1 year ago

v-rosa commented 1 year ago

I was testing the following demo: https://github.com/hashicorp/terraform-aws-hcp-consul/blob/main/examples/hcp-ecs-demo/main.tf

It relies on the mesk-task module of this repository to spin up an ECS service with all the needed side-cars.

Using Consul entreprise v1.13.3, its impossible to start the consul-client side car given the following error:

==> failed to parse /consul/agent-defaults.hcl: 1 error occurred:
* invalid config key telemetry.disable_compat_1.9

Looking at the release notes, this paramter should be removed from v1.13 onwards.

Given this mesk-task module is a dependency of the HCP feature which allows to bootstrap a Consul cluster with auto-generated terraform code, I would say it should fix by removing the parameter so users won't complain about a broken demo.

I can quickly open a PR to address it.

v-rosa commented 1 year ago

Never mind, its fixed already in main branch. Could you please release a hotfix for this?

pglass commented 1 year ago

Hi @v-rosa,

Thanks for opening this issue! We've released v0.5.2 of Consul ECS which adds support for Consul 1.13 and 1.14, so I'll close this out. Let us know if you run into any other issues.