search

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Add support for additional_execution_role_policies in acl-controller #151

Closed v-rosa closed 1 year ago

v-rosa commented 1 year ago

Refers to https://github.com/hashicorp/terraform-aws-consul-ecs/issues/150

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

cthain commented 1 year ago

@v-rosa The TF updates to the acl-controller module look good to me. Thanks so much for your contribution!

I only have a couple of housekeeping comments:

  1. I think that we should change the base branch for this PR to main so that it gets included in the next release. We can backport it to the release/0.5.x and release/0.4.x branches; and,
  2. We should include a changelog entry for visibility.

I don't want to add more work for you on this so let me know if you would like me to do these tasks.

Thanks again!

v-rosa commented 1 year ago

Done.

cthain commented 1 year ago

Thank you for the contribution @v-rosa. I will merge this to main and backport it to release/0.5.x and release/0.4.x.

polewskm commented 1 year ago

Any update on releasing this to 0.4.x and 0.5.x ?