Modify mesh-task and controller - Githubissues

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)

https://www.consul.io/docs/ecs

Mozilla Public License 2.0

52 stars 30 forks source link

Modify mesh-task and controller #188

Closed Ganeshrockz closed 1 year ago

Ganeshrockz commented 1 year ago

Changes proposed in this PR:

Makes changes for mesh-task and controller modules to align with the consul-dataplane based architecture in ECS.
Changed the named of acl-controller module to just controller
Removed client agent specific TF resources and tests.
Gateway related flows will be changed in the upcoming PRs.
HCP related changes will be made in the upcoming PRs. CI will also not test HCP.

How I've tested this PR:

Unit and integration tests.

How I expect reviewers to test this PR:

Checklist:

[x] Tests added
[ ] CHANGELOG entry added (Not needed. Will push this to a non default branch)

Ganeshrockz commented 1 year ago

@cthain / @pglass Can you re-review this PR whenever possible? Thanks 🙇

Ganeshrockz commented 1 year ago

@pglass I've addressed almost all the comments except the one that talks about the version. Please re-review it whenever possible. Thanks