search

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Is variable outbound_only really needed? #196

Closed v-rosa closed 1 year ago

v-rosa commented 1 year ago

Seems that variable outbound_only is used only to do some kind of asserts here : https://github.com/hashicorp/terraform-aws-consul-ecs/blob/39ddfcb89da7d4eda4ffcfaef7d7d099b20d4a6f/modules/mesh-task/validation.tf#L5

I'm trying to understand if this affects the consul side cars bootstrap in any way.

Am I missing something?

Ganeshrockz commented 1 year ago

👋 @v-rosa This does not affect the sidecar bootstrap in any way. This variable was just added to make sure users are aware of setting the port as 0 (when they forget to set one) because most services accept incoming traffic. I hope this answers your query.

Closing this issue for now. Feel free to reopen if you still have more queries around this.