search

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Fix windows line ending issue in mesh-task #2

Closed allisaurus closed 3 years ago

allisaurus commented 3 years ago

Running terraform apply from a Windows machine results in CRLF chars being added to the command of the consul-client container. Wrapping the command value in replace(), similar to what's done within the server module, prevents these from ending up in the resulting task definition.

Testing

Before change: image

After change: image

allisaurus commented 3 years ago

CLA signed: https://github.com/hashicorp/consul/pull/10280#issuecomment-846249907