Fix health check command for mesh and gateway task submodules

[Ganeshrockz]

Changes proposed in this PR:

• The ECS health check logic relies on the command returning a non zero exit code. In the current state, even when consul-ecs-control-plane returns back a 500 the curl command treats it a successful response and returns a non zero code. Here's an example of the same

ganeshseetharaman@ganeshseetharaman-DFCQN60JDW % curl -v httpbin.org/status/500 
*   Trying 3.95.102.170:80...
* Connected to httpbin.org (3.95.102.170) port 80 (#0)
> GET /status/500 HTTP/1.1
> Host: httpbin.org
> User-Agent: curl/8.1.2
> Accept: */*
> 
< HTTP/1.1 500 INTERNAL SERVER ERROR
< Date: Fri, 15 Dec 2023 08:26:54 GMT
< Content-Type: text/html; charset=utf-8
< Content-Length: 0
< Connection: keep-alive
< Server: gunicorn/19.9.0
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Credentials: true
< 
* Connection #0 to host httpbin.org left intact
ganeshseetharaman@ganeshseetharaman-DFCQN60JDW % echo $?                                                          
0

This caused the consul-dataplane container to start up before the consul binary became available in the shared volume. In an ideal world, consul-dataplane should only start up after the control-plane container writes the Consul ECS binary to the shared volume and returns back a 200 response code for the /consul-ecs/health endpoint.

This PR fixes the same by adding a -f flag to curl.

ganeshseetharaman@ganeshseetharaman-DFCQN60JDW % curl -v -f httpbin.org/status/500
*   Trying 18.214.18.233:80...
* Connected to httpbin.org (18.214.18.233) port 80 (#0)
> GET /status/500 HTTP/1.1
> Host: httpbin.org
> User-Agent: curl/8.1.2
> Accept: */*
> 
< HTTP/1.1 500 INTERNAL SERVER ERROR
< Date: Fri, 15 Dec 2023 08:30:02 GMT
< Content-Type: text/html; charset=utf-8
< Content-Length: 0
< Connection: keep-alive
< Server: gunicorn/19.9.0
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Credentials: true
* The requested URL returned error: 500
* Closing connection 0
curl: (22) The requested URL returned error: 500
ganeshseetharaman@ganeshseetharaman-DFCQN60JDW % echo $?                          
22

How I've tested this PR:

Manual deployment

How I expect reviewers to test this PR:

Checklist:

• [ ] Tests added n/a
• [X] CHANGELOG entry added

[lkysow]

Happy to merge this quickly but we need to look into why the acceptance tests didn't catch this.

[Ganeshrockz]

Happy to merge this quickly but we need to look into why the acceptance tests didn't catch this.

I am pretty sure something changed recently in ECS. I have never seen a single acceptance test run fail with this error until last week. Right now I am pretty much able to reproduce this everytime I trigger the same suite of acceptance tests. I am also constantly seeing this error whenever trying to deploy the examples present in this repo.