hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Add ACL controller module and enable ACLs for other components. #31

Closed ishustava closed 3 years ago

ishustava commented 3 years ago

The new controller module runs ACL controller implemented in consul-ecs for managing ACL for ECS tasks on the service mesh.

This PR also enables ACLs for the dev-server and the mesh-task modules.

Note for the reviewers: There are a couple of future improvements that will come in a later PR:

  1. Handling error cases when setting different ACL related vars (e.g. service name prefix should be required if acls are true)
  2. Possibly making polling interval(s) for the controller configurable
  3. Allowing users to bring their own tokens for services in case they don't want to run the controller.