search

hashicorp / terraform-aws-consul-ecs

Consul Service Mesh on AWS ECS (Elastic Container Service)
https://www.consul.io/docs/ecs
Mozilla Public License 2.0
52 stars 30 forks source link

Inject Consul Binary into mesh-init #53

Closed erichaberkorn closed 3 years ago

erichaberkorn commented 3 years ago

Changes proposed in this PR:

Inject the consul binary from the consul-client container into the consul-ecs-mesh-init container. This makes it possible for users to choose a Consul version rather than using the bundled Consul binary.

This works by:

  1. In the consul-ecs PR it adds /bin/consul-inject to PATH
  2. Creating the consul_binary volume
  3. Mounting the volume from the consul-client container and consul-ecs-mesh-init container
  4. Copying the consul binary to the volume from the consul-client container

How I've tested this PR:

I updated the consul-ecs container images to reference the ones created in the associated consul-ecs PR to ensure the tests pass and examples continue running as expected.

Merge process:

  1. Merge https://github.com/hashicorp/consul-ecs/pull/40
  2. Undo all of the changes to consul_ecs_image and ensure the tests pass
  3. Merge this

How I expect reviewers to test this PR:

👀

Checklist: