search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Tag key should be configurable to be consistent with other modules #12

Open dgrstl opened 7 years ago

dgrstl commented 7 years ago

https://github.com/hashicorp/terraform-aws-consul/blob/9e95fed34def65c0fdf5b2805f1a6c6d135efd2b/modules/consul-cluster/main.tf#L32

E.g., https://github.com/hashicorp/terraform-aws-nomad/blob/master/modules/nomad-cluster/main.tf#L31

brikis98 commented 7 years ago

Well, the tag key is configurable, but I suppose the Name key could also be made configurable. PRs welcome!

dgrstl commented 7 years ago

Sorry, this was not clear. The issue is that this module tags instances in one way (including the second tag with the hard coded tag key "The") whereas the vault and nomad modules do so very differently which makes using them together a little confusing and inconsistent. See https://github.com/hashicorp/terraform-aws-nomad/blob/master/modules/nomad-cluster/main.tf#L30-L34