search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Switch from supervisord to systemd #130

Closed edtan closed 5 years ago

edtan commented 5 years ago

Closes #86 by switching to Amazon Linux 2 and changing to systemd.

The consul.service configuration was based off of the configuration listed at the Consul Deployment Guide.

Etiene commented 5 years ago

Thanks for the PR! I'm gonna run the test suite now

edtan commented 5 years ago

No problem! Thank you for making these modules publicly available. They've been super useful!

Glad to hear the tests passed. I'm still trying to set up the tests on my machine, but have been testing the changes manually in my test environments.

brikis98 commented 5 years ago

Looks like the last commit had a test failure?

brikis98 commented 5 years ago

@Etiene Could you take over getting this PR passing tests and merged from here?

edtan commented 5 years ago

whoops, sorry! I'll try to re-run some tests locally this week, but if you have some stack traces and can give me some pointers, I'll be glad to rewrite the tests as necessary. Note that I don't have access to the enterprise images, and I'm kinda stingy on AWS fees so I try to limit launching instances :) but I kid - I'll run the relevant tests if I know which ones are failing. :))

edit: I ran all the tests locally and see some of them failing. I'll track this down and get back to you once resolved

edtan commented 5 years ago

Strange, I re-ran the (non-enterprise) tests again and they've passed now. Were the tests failing on the enterprise test case?

brikis98 commented 5 years ago

Looks like the test failure was TestConsulClusterWithUbuntuAmi due to: 

TestConsulClusterWithUbuntuAmi 2019-03-29T12:31:29Z command.go:94: 1553862689,,ui,error,==> ubuntu16-ami: Error creating AMI: InvalidAMIName.Duplicate: AMI name consul-ubuntu-2019-03-29T12-28-48Z is already in use by AMI ami-0f589d96558469b10\n==> ubuntu16-ami:   status code: 400%!(PACKER_COMMA) request id: 10801e75-981f-4231-bf0a-84a278a456ae

This is probably a minor, intermittent timing issue in the tests, not related to your changes. So I think this is good to merge!