search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Add iam_role_name to outputs of consul-cluster module. Fixes #106 #132

Closed tomaspinho closed 5 years ago

hashicorp-cla commented 5 years ago

CLA assistant check
All committers have signed the CLA.

brikis98 commented 5 years ago

Is this not the same as https://github.com/hashicorp/terraform-aws-consul/blob/master/modules/consul-cluster/outputs.tf#L21-L24 ?

tomaspinho commented 5 years ago

@brikis98, IAM Role IDs are not IAM Role Names. The Terraform AWS Provider takes the latter in most cases as input to other resources. Related issue is here: https://github.com/hashicorp/terraform-aws-consul/issues/106

brikis98 commented 5 years ago

Are you 100% sure? We use ID all over the place and the docs say that both return the same thing...

tomaspinho commented 5 years ago

@brikis98, you are right. There's a bit of docs confusion going on. Apparently name is the same as id as per: https://www.terraform.io/docs/providers/aws/r/iam_role.html Maybe we can close that issue, then?

brikis98 commented 5 years ago

Yea, it's definitely confusing. Closing now, thanks!