search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 488 forks source link

Support for Ubuntu 18.04 #141

Closed sharmaansh21 closed 5 years ago

sharmaansh21 commented 5 years ago

Is there any plan, in nearby future to support Ubuntu 18.04? If not, I am happy to work on AWS related modules to add support for 18.04 if it is OK with you guys. I can start with the Consul, but yes definitely need help/pointers from you guys.

@Etiene @brikis98

brikis98 commented 5 years ago

Yes, 18.04 is on our roadmap. @yorinasub17 Can comment on rough timeline.

sharmaansh21 commented 5 years ago

Cool, if you guys haven't started 18.04, I can look into it.

yorinasub17 commented 5 years ago

Hi @sharmaanshul2102 , we haven't started this yet, and most likely won't get to it until after the tf12 update is done. So would really appreciate a PR for it!

I will suggest starting by updating the packer build to add a new builder for ubuntu 18.04 (https://github.com/hashicorp/terraform-aws-consul/blob/master/examples/consul-ami/consul.json), and then adding a Ubuntu1804 test to the main consul-cluster test (https://github.com/hashicorp/terraform-aws-consul/blob/master/test/consul_cluster_test.go) that you can iterate on.