consul.json using old packer var

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer

Apache License 2.0

401 stars 484 forks source link

consul.json using old packer var #170

Closed punkrokk closed 4 years ago

punkrokk commented 4 years ago

clean_ami_name1 has been replaced byclean_resource_namein packer v1.4. Updatedconsul.json` to reflect this.

Ref: https://github.com/hashicorp/packer/pull/7456

The current consul.json template needs this update.

It might also make sense to update the readme for the consul template to provide a note about needing a vpc_id and/or subnet_id in order for the packer build to run.

Let me know.

brikis98 commented 4 years ago

Thx for the PR in #169!

The Packer template should, by default, use the Default VPC. vpc_id and subnet_id are only required if you don't have a default VPC.

punkrokk commented 4 years ago

@brikis98 Makes Sense. I think PR #169 is ready to go then.

Unless you want me to put blank vars in there.