search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
399 stars 482 forks source link

Set up http_api access correctly #218

Closed mr-miles closed 3 years ago

mr-miles commented 3 years ago

Received an error using the module in our terraform:

Error: One of ['cidr_blocks', 'ipv6_cidr_blocks', 'self', 'source_security_group_id', 'prefix_list_ids'] must be set to create an AWS Security Group Rule Error on .terraform/modules/consul_servers/modules/consul-security-group-rules/main.tf line 70, in resource "aws_security_group_rule" "allow_https_api_inbound": Error: resource "aws_security_group_rule" "allow_https_api_inbound" {

If the module is given only security groups and not cidr ranges, a security group rule is created without all the necessary attributes. Change applies the right boolean logic for this case.

brikis98 commented 3 years ago

Tests passed! Merging now.

brikis98 commented 3 years ago

https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.9.2

mr-miles commented 3 years ago

thanks for the quick turnaround!

On Mon, May 3, 2021 at 11:58 AM Yevgeniy Brikman @.***> wrote:

https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.9.2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hashicorp/terraform-aws-consul/pull/218#issuecomment-831186128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEQD4EOGPYRQJ3PNYCGQTTTLZ6W5ANCNFSM43U2TEMQ .