search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 488 forks source link

Migrate to templatefile function from deprecated template_file provider. #226

Closed lsc closed 3 years ago

lsc commented 3 years ago

The provider template_file is deprecated and it is encouraged to migrate to the built in templatefile() function.

As template_file is archived it also means that it's lacking builds for M1 macs.

lsc commented 3 years ago

Thanks for the fix! Overall, changes LGTM.

One request: please run terraform fmt on all the code, our our pre-commit hook will fail.

Will do!

Update All files should already be fmt:ed

terraform-aws-consul on  templatefunction-migrate [!] via 💠 default
❯ tf fmt -recursive -check

terraform-aws-consul on  templatefunction-migrate [!] via 💠 default
❯ echo $status
0
brikis98 commented 3 years ago

Ah, OK, great. Kicking off tests now.

brikis98 commented 3 years ago

Tests passed! Merging now.