search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Remove provider and aws_region from examples #65

Closed brikis98 closed 6 years ago

brikis98 commented 6 years ago

Fixes #49.

I’m removing the provider block and aws_region variable from the examples in this repo so that they work properly with the instructions you get from the auto-generated docs on the Terraform Registry page for this module:

module "consul" {
  source  = "hashicorp/consul/aws"
  version = "0.3.3"
}
ballPointPenguin commented 6 years ago

I believe the Getting Started Docs should be updated to reflect this change: https://www.terraform.io/intro/getting-started/modules.html

Following those directions, I encounter:

Error: module "consul": "aws_region" is not a valid argument
brikis98 commented 6 years ago

Ah, good catch. Those docs are in a separate repo, but I'll submit a PR.

brikis98 commented 6 years ago

https://github.com/hashicorp/terraform/pull/18338

ballPointPenguin commented 6 years ago

Thanks!