hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Change how we publish public AMIs #77

Closed brikis98 closed 6 years ago

brikis98 commented 6 years ago

Our AMI publishing script seemed to be broken (https://github.com/hashicorp/terraform-aws-consul/issues/76). I was struggling to figure out why and realized that Packer can now do most of what that script does with the ami_regions and ami_groups parameters. I made those changes... and then realized that the actual issue was that we were publishing the AMIs to the wrong account (to Phx DevOps rather than our public AMIs account). Doh.

Overall, I think this solution is simpler and better overall, so perhaps my work has not gone to waste.

brikis98 commented 6 years ago

Test failure is due to lack of a published AMI! Merging now and will create a new release to check this all works.