search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

Inbound required arguments. #87

Closed jarrettj closed 5 years ago

jarrettj commented 5 years ago

Hi,

Good day.

I'm using the consul_cluster module. Quick question, why is allowed_inbound_cidr_blocks required? If my cluster is deployed in a private subnet, would allowed_inbound_cidr_blocks be needed? If we only allowing access from a bastion instance, only allowed_inbound_security_group_ids would be needed.

Maybe have one of allowed_inbound_cidr_blocks or allowed_inbound_security_group_ids required? I might also be completely wrong and missed something? :)

Regards. JJ

Etiene commented 5 years ago

To be honest, I also don't see any reason for it to be required, so I guess we could update that (PRs welcome as well). For the moment passing an empty list would be ok :)

jarrettj commented 5 years ago

No worries. I’ll just add that then. Thanks.

On 22 Oct 2018, at 18:55, Etiene Dalcol notifications@github.com wrote:

To be honest, I also don't see any reason for it to be required, so I guess we could update that (PRs welcome as well). For the moment passing an empty list would be ok :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

jarrettj commented 5 years ago

Awesome, the empty list worked. :)