search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 484 forks source link

adds optional variable for enabling specified autoscaling group metrics #99

Closed eedwards-sk closed 5 years ago

eedwards-sk commented 5 years ago

closes #98

eedwards-sk commented 5 years ago

I switched my current project to using this fork/branch to test the change.

I confirmed it's a non-breaking change that supports enabling additional metrics, if specified.

e.g. to my terraform file (that consumes the module) I added:

  enabled_metrics = [
    "GroupMinSize",
    "GroupMaxSize",
    "GroupDesiredCapacity",
    "GroupInServiceInstances",
    "GroupPendingInstances",
    "GroupStandbyInstances",
    "GroupTerminatingInstances",
    "GroupTotalInstances"
  ]

upon execution against existing cluster, my plan output is:

- module.consul_cluster
  Getting source "github.com/eedwards-sk/terraform-aws-consul//modules/consul-cluster?ref=GH-98"

...

------------------------------------------------------------------------

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ module.consul_cluster.aws_autoscaling_group.autoscaling_group
      enabled_metrics.#:          "0" => "8"
      enabled_metrics.119681000:  "" => "GroupStandbyInstances"
      enabled_metrics.1940933563: "" => "GroupTotalInstances"
      enabled_metrics.308948767:  "" => "GroupPendingInstances"
      enabled_metrics.3267518000: "" => "GroupTerminatingInstances"
      enabled_metrics.3394537085: "" => "GroupDesiredCapacity"
      enabled_metrics.3551801763: "" => "GroupInServiceInstances"
      enabled_metrics.4118539418: "" => "GroupMinSize"
      enabled_metrics.4136111317: "" => "GroupMaxSize"

Plan: 0 to add, 1 to change, 0 to destroy.

and the apply

module.consul_cluster.aws_autoscaling_group.autoscaling_group: Modifying... (ID: eedwards-dev-consul-cluster20181112203632309200000008)
  enabled_metrics.#:          "0" => "8"
  enabled_metrics.119681000:  "" => "GroupStandbyInstances"
  enabled_metrics.1940933563: "" => "GroupTotalInstances"
  enabled_metrics.308948767:  "" => "GroupPendingInstances"
  enabled_metrics.3267518000: "" => "GroupTerminatingInstances"
  enabled_metrics.3394537085: "" => "GroupDesiredCapacity"
  enabled_metrics.3551801763: "" => "GroupInServiceInstances"
  enabled_metrics.4118539418: "" => "GroupMinSize"
  enabled_metrics.4136111317: "" => "GroupMaxSize"
module.consul_cluster.aws_autoscaling_group.autoscaling_group: Modifications complete after 2s (ID: eedwards-dev-consul-cluster20181112203632309200000008)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
brikis98 commented 5 years ago

https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.4.3