feat(proxy): allowing module users to specify egress proxy settings - Githubissues

hashicorp / terraform-aws-terraform-enterprise-hvd

A Terraform module for provisioning and installing Terraform Enterprise on AWS EC2 as described in HashiCorp Validated Designs

Mozilla Public License 2.0

6 stars 6 forks source link

feat(proxy): allowing module users to specify egress proxy settings #7

Closed calvo2024 closed 2 weeks ago

calvo2024 commented 1 month ago

Description

Variables http_proxy, https_proxy and additional_no_proxy have been added to the module, allowing it to enforce egress traffic to go through a forward proxy.

Related issue

N/A

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update

How has this been tested?

Deploy a squid proxy within the prerequisites network.
For each container runtime (docker, podman) deploy the module with and without enforcing egress traffic to go through the proxy.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

hashicorp-cla-app[bot] commented 1 month ago

All committers have signed the CLA.

roooms commented 1 month ago

@alexbasista please consider this along with your planned updates for the next release.

alexbasista commented 3 weeks ago

AWS S3 and Secrets Manager endpoints need to be dynamically added to no_proxy before this is complete.

roooms commented 3 weeks ago

Adding @calvo2024 as an assignee to consider feedback from @alexbasista and way forward.