hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

Fix shellcheck warnings #215

Closed yorinasub17 closed 2 years ago

yorinasub17 commented 4 years ago

This resolves some of the obvious shellcheck warnings. There are still a few more, but they require a bit more digging to fully grasp what is being called out so I decided to leave them untouched.

brikis98 commented 4 years ago

Note I'm hold off on merges due to https://github.com/hashicorp/terraform-aws-vault/pull/195. Haven't had time to dig into that yet.

brikis98 commented 4 years ago

OK, https://github.com/hashicorp/terraform-aws-vault/pull/195 is merged, will kick off tests.

brikis98 commented 4 years ago

Oh, doh, this hasn't had master merged in yet!

brikis98 commented 4 years ago

Yori, could you rebase, and then I can kick off tests again.

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

yorinasub17 commented 2 years ago

Closing as outdated