hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

Fixed link to "Latest Amazon Linux 2 AMIs" #225

Closed domenjesenovec closed 3 years ago

domenjesenovec commented 3 years ago

Fixed link to "Latest Amazon Linux 2 AMIs"

The link took me to the wrong page, I used the outdated AMI and then I spent about an hour wondering how come DynamoDB is not supported etc.

hashicorp-cla commented 3 years ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

brikis98 commented 3 years ago

Thanks for the fix! Note that as of https://github.com/hashicorp/terraform-aws-vault/pull/224, we are actually going to stop updating these Markdown files with AMI lists, so I'm going to close this PR. Note that we will continue publishing the AMIs themselves; it's just the Markdown files that are going away. You can still find the AMI IDs by doing a search in the AWS Marketplace or programmatically using tools like the aws_ami data source in Terraform.