Fixing tests using consul for dns

hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer

Apache License 2.0

656 stars 465 forks source link

Fixing tests using consul for dns #232

Closed anouarchattouna closed 3 years ago

anouarchattouna commented 3 years ago

Refactoring tests
- Add a new test stage initialize_unseal useful when running multiple times the validation stage against the same cluster
- Add testVaultUsesConsulForDns for all test cases
Updating vault service configuration
- Adding service_registration used when using a different storage backend like s3
- Updating systemd configuration based on this configure-systemd documentation
Bumping versions
- bump min_packer_version -> 1.5.4
- bump vault_version -> 1.6.1
- bump consul_version -> 1.9.2

brikis98 commented 3 years ago

Tests passed! 🎉

So does this imply there's no actual bug with https://github.com/hashicorp/terraform-aws-vault/issues/228 / Ubuntu 18.04? That it was just that the service wasn't being registered? Or did we need newer Consul / Vault versions?

anouarchattouna commented 3 years ago

Tests passed! 🎉

So does this imply there's no actual bug with #228 / Ubuntu 18.04? That it was just that the service wasn't being registered? Or did we need newer Consul / Vault versions?

Indeed, it resolves #228 by adding the service registration and using newer Consul / Vault versions

brikis98 commented 3 years ago

Tests passed! 🎉 So does this imply there's no actual bug with #228 / Ubuntu 18.04? That it was just that the service wasn't being registered? Or did we need newer Consul / Vault versions?

Indeed, it resolves #228 by adding the service registration and using newer Consul / Vault versions

Sorry, crazy week, just coming back to this now. That's great news, thank you! I'm going to merge and release this now.

brikis98 commented 3 years ago

https://github.com/hashicorp/terraform-aws-vault/releases/tag/v0.14.2