Pull request 235 - Githubissues

hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer

Apache License 2.0

656 stars 465 forks source link

Pull request 235 #237

Closed queglay closed 3 years ago

queglay commented 3 years ago

Added optional --skip-package-update arg to bypass yum/apt updates

hashicorp-cla commented 3 years ago

All committers have signed the CLA.

brikis98 commented 3 years ago

Ah, tests failed, but due to an unrelated reason: ap-northeast-3 doesn't have the dedicated KMS key we set up for automated tests in our AWS account. I know it's not part of this PR, but would you mind adding ap-northeast-3 to the exclude list here? I can then re-run the tests.

queglay commented 3 years ago

No worries, I've just added ap-northeast-3 to exclude list

brikis98 commented 3 years ago

Thanks! I'll re-run the tests now.

brikis98 commented 3 years ago

Tests passed! Merging now.