search

hashicorp / terraform-aws-vault

A Terraform Module for how to run Vault on AWS using Terraform and Packer
Apache License 2.0
656 stars 465 forks source link

addresses https://github.com/hashicorp/terraform-aws-vault/issues/238 #239

Closed dchernivetsky closed 3 years ago

hashicorp-cla commented 3 years ago

CLA assistant check
All committers have signed the CLA.

dchernivetsky commented 3 years ago

238

dchernivetsky commented 3 years ago

@brikis98 corrected the findings.

dchernivetsky commented 3 years ago

corrected all @brikis98

brikis98 commented 3 years ago

Tests passed! Merging now.

brikis98 commented 3 years ago

https://github.com/hashicorp/terraform-aws-vault/releases/tag/v0.14.3

dchernivetsky commented 3 years ago

@brikis98 on second thought. I just tried to use 0.14.3 It doesnt appear that approach taken in the PR is valid. Specifically with ["once"] snippet.

Error: Invalid function argument

  on .terraform/modules/vault_cluster_elb/modules/vault-elb/main.tf line 32, in resource "aws_elb" "vault":
  32:       enabled       = lookup(access_logs.value, "enabled", lookup(access_logs.value, "bucket", null))
    |----------------
    | access_logs.value is "once"

Invalid value for "inputMap" parameter: lookup() requires a map as the first
argument.
brikis98 commented 3 years ago

Ah, yea, it should be var.access_logs instead of access_logs.value.